lkml.org 
[lkml]   [2014]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/1] staging: rtl8192u: Move ieee80211_crypto_* declarations to ieee80211/ieee80211.h
On Wed, Sep 17, 2014 at 09:24:03PM +0000, Ragnar B. Johannsson wrote:

> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> index bdad3a2..d56c3aac 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> @@ -2445,6 +2445,15 @@ extern void ieee80211_tkip_null(void);
> extern void ieee80211_wep_null(void);
> extern void ieee80211_ccmp_null(void);
>
> +extern int ieee80211_crypto_init(void);
> +extern void ieee80211_crypto_deinit(void);
> +extern int ieee80211_crypto_tkip_init(void);
> +extern void ieee80211_crypto_tkip_exit(void);
> +extern int ieee80211_crypto_ccmp_init(void);
> +extern void ieee80211_crypto_ccmp_exit(void);
> +extern int ieee80211_crypto_wep_init(void);
> +extern void ieee80211_crypto_wep_exit(void);
> +

We don't normally put the extern here. I don't think it adds anything
to the readability. Let's remove it.

regards,
dan carpenter



\
 
 \ /
  Last update: 2014-09-18 00:21    [W:0.059 / U:2.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site