Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH] net: can: usb: peak_usb: pcan_usb_core.c: Cleaning up missing null-terminate in conjunction with strncpy | Date | Tue, 16 Sep 2014 08:40:57 +0000 |
| |
From: Rickard Strandqvist > > 2014-09-15 10:47 GMT+02:00 David Laight <David.Laight@aculab.com>: ... > > Or: > > char name[sizeof netdev->name]; > > memcpy(name, netdev->name, sizeof netdev->name); > > ... > I liked the variant: > char name[sizeof(netdev->name)]; > > But dislike and do not understand what the point would be with memcpy variant.
The memcpy() will be a lot faster than any of the string copy functions because it doesn't need to worry about the terminator. In many cases it will be inlined to a short series of load and stores.
David
| |