Messages in this thread Patch in this message | | | Subject | Re: [PATCH] staging: dgap: use schedule_timeout_interruptible() instead of dgap_ms_sleep() | From | Joe Perches <> | Date | Tue, 16 Sep 2014 00:54:52 -0700 |
| |
On Tue, 2014-09-16 at 09:31 +0300, Dan Carpenter wrote: > There is no point in calling signal_pending() if you don't care about > the return value.
So maybe make it __must_check? --- include/linux/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h index 7d799ea..03273c0 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -2692,7 +2692,7 @@ static inline int restart_syscall(void) return -ERESTARTNOINTR; } -static inline int signal_pending(struct task_struct *p) +static inline int __must_check signal_pending(struct task_struct *p) { return unlikely(test_tsk_thread_flag(p,TIF_SIGPENDING)); }
| |