lkml.org 
[lkml]   [2014]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] locking/rwsem-spinlock: Cleanup down_read()

* Davidlohr Bueso <dave@stgolabs.net> wrote:

> ... when returning from a successful lock acquisition. The horror!
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> kernel/locking/rwsem-spinlock.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel/locking/rwsem-spinlock.c b/kernel/locking/rwsem-spinlock.c
> index 2c93571..07e456c 100644
> --- a/kernel/locking/rwsem-spinlock.c
> +++ b/kernel/locking/rwsem-spinlock.c
> @@ -130,7 +130,7 @@ void __sched __down_read(struct rw_semaphore *sem)
> /* granted */
> sem->count++;
> raw_spin_unlock_irqrestore(&sem->wait_lock, flags);
> - goto out;
> + return;
> }
>
> tsk = current;
> @@ -155,8 +155,6 @@ void __sched __down_read(struct rw_semaphore *sem)
> }
>
> tsk->state = TASK_RUNNING;
> - out:
> - ;
> }

It following an existing 'out' pattern found elsewhere in the
file - I don't think there's much wrong about that per se -
especially in locking code we try to not return from the middle
of the flow.

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-09-16 10:21    [W:0.827 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site