Messages in this thread | | | Date | Tue, 16 Sep 2014 17:20:46 +0200 | From | Markus Trippelsdorf <> | Subject | Re: [PATCH] printk: git rid of [sched_delayed] message for printk_deferred |
| |
On 2014.09.16 at 11:13 -0400, Steven Rostedt wrote: > On Tue, 16 Sep 2014 16:42:52 +0200 > Markus Trippelsdorf <markus@trippelsdorf.de> wrote: > > > commit 458df9fd hardcodes printk_deferred() to KERN_WARNING and inserts > > the string "[sched_delayed] " before the actual message. > > However it doesn't take into account the KERN_* prefix of the message, > > that now ends up in the middle of the output: > > > > [sched_delayed] ^a4CE: hpet increased min_delta_ns to 20115 nsec > > > > Fix this by just getting rid of the "[sched_delayed] " scnprintf(). > > I prefer the "[sched_delayed]" output. It lets us know that the output > did not come out immediately, which is important sometimes during > debugging. Otherwise it can confuse people, as printk is suppose to be > a blocking write. > > Can we instead fix the bug instead of nuking the output? That is, move > the KERN_* prefix before the "[sched_delayed]" message? I don't think > it would be that hard. If you want, I'll write that patch (probably > take me 20 minutes at most), but I'm just coming back from medical > leave so I prefer not to.
I'll leave it to you. This is just a cosmetic issue, so there's no need to fix this immediately.
-- Markus
| |