lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16 007/158] media: mt9v032: fix hblank calculation
    Date
    3.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Philipp Zabel <p.zabel@pengutronix.de>

    commit f17bc3f4707eb87bdb80b895911c551cdd606fbd upstream.

    Since (min_row_time - crop->width) can be negative, we have to do a signed
    comparison here. Otherwise max_t casts the negative value to unsigned int
    and sets min_hblank to that invalid value.

    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
    Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/i2c/mt9v032.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/media/i2c/mt9v032.c
    +++ b/drivers/media/i2c/mt9v032.c
    @@ -305,8 +305,8 @@ mt9v032_update_hblank(struct mt9v032 *mt

    if (mt9v032->version->version == MT9V034_CHIP_ID_REV1)
    min_hblank += (mt9v032->hratio - 1) * 10;
    - min_hblank = max_t(unsigned int, (int)mt9v032->model->data->min_row_time - crop->width,
    - (int)min_hblank);
    + min_hblank = max_t(int, mt9v032->model->data->min_row_time - crop->width,
    + min_hblank);
    hblank = max_t(unsigned int, mt9v032->hblank, min_hblank);

    return mt9v032_write(client, MT9V032_HORIZONTAL_BLANKING, hblank);



    \
     
     \ /
      Last update: 2014-09-16 00:01    [W:4.342 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site