Messages in this thread | | | Date | Mon, 15 Sep 2014 14:15:23 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/7] Prepare for adding a new readv/writev with user flags. |
| |
On Mon, Sep 15, 2014 at 09:28:28PM +0100, Al Viro wrote: > On Mon, Sep 15, 2014 at 04:20:17PM -0400, Milosz Tanski wrote: > > Plumbing the flags argument through the vfs code so they can be passed down to > > __generic_file_(read/write)_iter function that do the acctual work. > > NAK. Put these flags into iocb, it'll be less noisy that way.
Fine with me. My initial prototype had it in the iov_iter type field which is another possibility.
But if we get rid of the explicit flags field and make it more invisible I'd really like to add a features field struct file_operations where instances can advertize that they support it (and other things like actual AIO support in the future) so that we won't have a situation like with AIO where we can submit I/O but it might actually still block anyway because lots of operations don't support it.
| |