lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16 058/158] SCSI: save command pool address of Scsi_Host
    Date
    3.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Juergen Gross <jgross@suse.com>

    commit f6105c0808880c2c432b79bc81b37cc244c300c8 upstream.

    If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's
    private command pool is needed. scsi_find_host_cmd_pool() will locate it, but
    scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template.

    This will result in an access error when the host is removed.

    Avoid the problem by saving the address of a new allocated command pool where
    it is expected.

    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Fixes: 89d9a567952baec13e26ada3e438f1b642d66b6e
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/scsi.c | 12 ++++++++++--
    1 file changed, 10 insertions(+), 2 deletions(-)

    --- a/drivers/scsi/scsi.c
    +++ b/drivers/scsi/scsi.c
    @@ -380,6 +380,10 @@ scsi_alloc_host_cmd_pool(struct Scsi_Hos
    pool->slab_flags |= SLAB_CACHE_DMA;
    pool->gfp_mask = __GFP_DMA;
    }
    +
    + if (hostt->cmd_size)
    + hostt->cmd_pool = pool;
    +
    return pool;
    }

    @@ -424,8 +428,10 @@ out:
    out_free_slab:
    kmem_cache_destroy(pool->cmd_slab);
    out_free_pool:
    - if (hostt->cmd_size)
    + if (hostt->cmd_size) {
    scsi_free_host_cmd_pool(pool);
    + hostt->cmd_pool = NULL;
    + }
    goto out;
    }

    @@ -447,8 +453,10 @@ static void scsi_put_host_cmd_pool(struc
    if (!--pool->users) {
    kmem_cache_destroy(pool->cmd_slab);
    kmem_cache_destroy(pool->sense_slab);
    - if (hostt->cmd_size)
    + if (hostt->cmd_size) {
    scsi_free_host_cmd_pool(pool);
    + hostt->cmd_pool = NULL;
    + }
    }
    mutex_unlock(&host_cmd_pool_mutex);
    }



    \
     
     \ /
      Last update: 2014-09-15 23:41    [W:4.062 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site