Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH] net: can: usb: peak_usb: pcan_usb_core.c: Cleaning up missing null-terminate in conjunction with strncpy | Date | Mon, 15 Sep 2014 08:28:26 +0000 |
| |
From: Rickard Strandqvist ... > Replacing strncpy with strlcpy to avoid strings that lacks null terminate. ... > diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c > b/drivers/net/can/usb/peak_usb/pcan_usb_core.c > index 644e6ab..d4fe8ac 100644 > --- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c > +++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c > @@ -830,7 +830,7 @@ static void peak_usb_disconnect(struct usb_interface *intf) > char name[IFNAMSIZ]; > > dev->state &= ~PCAN_USB_STATE_CONNECTED; > - strncpy(name, netdev->name, IFNAMSIZ); > + strlcpy(name, netdev->name, IFNAMSIZ); > > unregister_netdev(netdev); > free_candev(netdev);
Or: char name[sizeof netdev->name]; memcpy(name, netdev->name, sizeof netdev->name);
David
| |