Messages in this thread | | | Date | Mon, 15 Sep 2014 11:23:46 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: lustre: lustre: libcfs: debug.c: Cleaning up unnecessary use of memset in conjunction with strncpy |
| |
On Sun, Sep 14, 2014 at 06:03:16PM +0200, Rickard Strandqvist wrote: > Using memset before strncpy just to ensure a trailing null > character is an unnecessary double writing of a string >
You really should make a function which pads and NUL terminates.
I've said this before, of course, but you haven't even tried.
I can't get excited about these cleanups which open code NUL termination every where. They are risky and have introduced bugs before.
regards, dan carpenter
| |