lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 040/114] scsi: do not issue SCSI RSOC command to Promise Vtrak E610f
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Janusz Dziemidowicz <rraptorr@nails.eu.org>

    commit 0213436a2cc5e4a5ca2fabfaa4d3877097f3b13f upstream.

    Some devices don't like REPORT SUPPORTED OPERATION CODES and will
    simply timeout causing sd_mod init to take a very very long time.
    Introduce BLIST_NO_RSOC scsi scan flag, that stops RSOC from being
    issued. Add it to Promise Vtrak E610f entry in scsi scan
    blacklist. Fixes bug #79901 reported at
    https://bugzilla.kernel.org/show_bug.cgi?id=79901

    Fixes: 98dcc2946adb ("SCSI: sd: Update WRITE SAME heuristics")

    Signed-off-by: Janusz Dziemidowicz <rraptorr@nails.eu.org>
    Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/scsi_devinfo.c | 1 +
    drivers/scsi/scsi_scan.c | 6 ++++++
    include/scsi/scsi_devinfo.h | 2 ++
    3 files changed, 9 insertions(+)

    --- a/drivers/scsi/scsi_devinfo.c
    +++ b/drivers/scsi/scsi_devinfo.c
    @@ -222,6 +222,7 @@ static struct {
    {"PIONEER", "CD-ROM DRM-602X", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
    {"PIONEER", "CD-ROM DRM-604X", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
    {"PIONEER", "CD-ROM DRM-624X", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
    + {"Promise", "VTrak E610f", NULL, BLIST_SPARSELUN | BLIST_NO_RSOC},
    {"Promise", "", NULL, BLIST_SPARSELUN},
    {"QUANTUM", "XP34301", "1071", BLIST_NOTQ},
    {"REGAL", "CDC-4X", NULL, BLIST_MAX5LUN | BLIST_SINGLELUN},
    --- a/drivers/scsi/scsi_scan.c
    +++ b/drivers/scsi/scsi_scan.c
    @@ -922,6 +922,12 @@ static int scsi_add_lun(struct scsi_devi
    if (*bflags & BLIST_USE_10_BYTE_MS)
    sdev->use_10_for_ms = 1;

    + /* some devices don't like REPORT SUPPORTED OPERATION CODES
    + * and will simply timeout causing sd_mod init to take a very
    + * very long time */
    + if (*bflags & BLIST_NO_RSOC)
    + sdev->no_report_opcodes = 1;
    +
    /* set the device running here so that slave configure
    * may do I/O */
    ret = scsi_device_set_state(sdev, SDEV_RUNNING);
    --- a/include/scsi/scsi_devinfo.h
    +++ b/include/scsi/scsi_devinfo.h
    @@ -35,4 +35,6 @@
    #define BLIST_SCSI3LUN 0x8000000 /* Scan more than 256 LUNs
    for sequential scan */
    #define BLIST_TRY_VPD_PAGES 0x10000000 /* Attempt to read VPD pages */
    +#define BLIST_NO_RSOC 0x20000000 /* don't try to issue RSOC */
    +
    #endif



    \
     
     \ /
      Last update: 2014-09-15 23:01    [W:3.030 / U:0.904 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site