lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 032/114] Drivers: scsi: storvsc: Filter commands based on the storage protocol version
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "K. Y. Srinivasan" <kys@microsoft.com>

    commit 8caf92d80526f3d7cc96831ec18b384ebcaccdf0 upstream.

    Going forward it is possible that some of the commands that are not currently
    implemented will be implemented on future Windows hosts. Even if they are not
    implemented, we are told the host will corrrectly handle unsupported
    commands (by returning appropriate return code and sense information).
    Make command filtering depend on the host version.

    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/storvsc_drv.c | 16 +++++++++++++---
    1 file changed, 13 insertions(+), 3 deletions(-)

    --- a/drivers/scsi/storvsc_drv.c
    +++ b/drivers/scsi/storvsc_drv.c
    @@ -1564,9 +1564,19 @@ static int storvsc_queuecommand(struct S
    struct vmscsi_request *vm_srb;
    struct stor_mem_pools *memp = scmnd->device->hostdata;

    - if (!storvsc_scsi_cmd_ok(scmnd)) {
    - scmnd->scsi_done(scmnd);
    - return 0;
    + if (vmstor_current_major <= VMSTOR_WIN8_MAJOR) {
    + /*
    + * On legacy hosts filter unimplemented commands.
    + * Future hosts are expected to correctly handle
    + * unsupported commands. Furthermore, it is
    + * possible that some of the currently
    + * unsupported commands maybe supported in
    + * future versions of the host.
    + */
    + if (!storvsc_scsi_cmd_ok(scmnd)) {
    + scmnd->scsi_done(scmnd);
    + return 0;
    + }
    }

    request_size = sizeof(struct storvsc_cmd_request);



    \
     
     \ /
      Last update: 2014-09-15 22:21    [W:4.330 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site