lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: randconfig build error with next-20140915, in drivers/input/misc/palmas-pwrbutton.c
On 09/15/2014 12:30 PM, Nishanth Menon wrote:
> On 09/15/2014 09:40 AM, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol
>> 'platform_driver_unregister'
>> make[1]: *** [__modpost] Error 1
>>
> For some reason, I was unable to reproduce this in my build with ARM
> OMAP5 configuration... but with the x86 configuration, I was.
>
> https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=adff5962fdd2f29bac943bc014ebd529444b2153
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n101
>
> I used MODULE_LICENSE("GPL V2")
>
> Looks like a typo crept in. And s/V/v seems to squelch the warning(at
> least in the x86 build) for the randconfig. I will post a patch
> accordingly. Thanks for catching the same.
>
> diff --git a/drivers/input/misc/palmas-pwrbutton.c
> b/drivers/input/misc/palmas-pwrbutton.c
> index 3f90211..06ffe04 100644
> --- a/drivers/input/misc/palmas-pwrbutton.c
> +++ b/drivers/input/misc/palmas-pwrbutton.c
> @@ -326,5 +326,5 @@ module_platform_driver(palmas_pwron_driver);
>
> MODULE_ALIAS("platform:palmas-pwrbutton");
> MODULE_DESCRIPTION("Palmas Power Button");
> -MODULE_LICENSE("GPL V2");
> +MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Texas Instruments Inc.");
>

To close this thread, posted:
https://patchwork.kernel.org/patch/4907121/


--
Regards,
Nishanth Menon


\
 
 \ /
  Last update: 2014-09-15 21:21    [W:0.036 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site