Messages in this thread | | | Date | Mon, 15 Sep 2014 11:30:13 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [RFC] arm:extend the reserved mrmory for initrd to be page aligned |
| |
On Mon, Sep 15, 2014 at 06:22:12PM +0800, Wang, Yalin wrote: > Oh, I see your meaning, > Yeah , my initrd is a cpio image, > And it can still work after apply this patch.
Okay, that's what I wanted to know. However, I believe your patch to be incorrect. You delete the assignments to initrd_start and initrd_end in arm_memblock_init(), which will result in non-OF platforms having no initrd.
The reason is that OF platforms set initrd_start and initrd_size from the OF code (drivers/of/fdt.c), but ATAG platforms only set our private phys_* versions.
The reason I went with phys_* stuff was to permit better verification of the addresses passed - that the addresses were indeed memory locations before passing them through something like __va().
-- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.
| |