lkml.org 
[lkml]   [2014]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 052/187] ASoC: max98090: Fix missing free_irq
    Date
    3.13.11.7 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jarkko Nikula <jarkko.nikula@linux.intel.com>

    commit 4adeb0ccf86a5af1825bbfe290dee9e60a5ab870 upstream.

    max98090.c doesn't free the threaded interrupt it requests. This causes
    an oops when doing "cat /proc/interrupts" after snd-soc-max98090.ko is
    unloaded.

    Fix this by requesting the interrupt by using devm_request_threaded_irq().

    Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@linaro.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    sound/soc/codecs/max98090.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
    index 9ad8f01..764d0ea 100644
    --- a/sound/soc/codecs/max98090.c
    +++ b/sound/soc/codecs/max98090.c
    @@ -2250,7 +2250,7 @@ static int max98090_probe(struct snd_soc_codec *codec)
    /* Register for interrupts */
    dev_dbg(codec->dev, "irq = %d\n", max98090->irq);

    - ret = request_threaded_irq(max98090->irq, NULL,
    + ret = devm_request_threaded_irq(codec->dev, max98090->irq, NULL,
    max98090_interrupt, IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
    "max98090_interrupt", codec);
    if (ret < 0) {
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-09-16 01:01    [W:3.614 / U:2.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site