Messages in this thread | | | Date | Fri, 12 Sep 2014 18:14:23 -0400 (EDT) | Subject | Re: [PATCH v2 3/4] net: stmmac: add support for Intel Quark X1000 | From | David Miller <> |
| |
From: Kweh Hock Leong <hock.leong.kweh@intel.com> Date: Thu, 11 Sep 2014 16:38:39 +0800
> + if ((!strcmp(quark_x1000_phy_info[i].board_name, board_name)) && > + quark_x1000_phy_info[i].pci_func_num == func_num)
It is entirely erroneous to identify a device by it's _PHYSICAL_ geographic location on the PCI bus.
Please get rid of this PCI function number comparison and if necessary find another means of identification.
| |