Messages in this thread | | | Date | Fri, 12 Sep 2014 19:41:56 +0530 | From | Kishon Vijay Abraham I <> | Subject | Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci |
| |
Hi,
On Friday 12 September 2014 07:19 PM, Heikki Krogerus wrote: > On Thu, Sep 11, 2014 at 08:31:19PM +0530, Kishon Vijay Abraham I wrote: >>> @@ -60,22 +59,33 @@ int dwc3_host_init(struct dwc3 *dwc) >>> goto err1; >>> } >>> >>> + phy_create_lookup(dwc->usb2_generic_phy, "usb2-phy", >>> + dev_name(&xhci->dev)); >>> + phy_create_lookup(dwc->usb3_generic_phy, "usb3-phy", >>> + dev_name(&xhci->dev)); >>> + >> >> I don't think create lookup should be in host init. If it's dt boot, the >> binding should be in dt data or for other boot modes the bindig should be done >> in the board file. This just seems hacky to me. > > So are you now suggesting that instead of using platform independent > solution of sharing the PHYs here, you would have us add platform > specific quirks? That would be totally wrong!
No. The binding between the controller and the PHY is done in hardware design and it would be wrong to create such a binding in drivers/* IMO. > > And please don't even consider use of board files especially if there > is an option. They are the one thing that we are meant to avoid if > possible! No?
For dt yes, I'm not sure about other modes.
So in the case of dt boot, I'd prefer giving the binding in dt file than anywhere else.
Thanks Kishon
| |