[lkml]   [2014]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5] ASoC: dapm: add code to configure dai link parameters
On Thu, Sep 11, 2014 at 11:42:18AM +0100, Nikesh Oswal wrote:

> + /* add kcontrol */
> + for (i = 0; i < w->num_kcontrols; i++) {
> + kcontrol = snd_soc_cnew(&w->kcontrol_news[i], w,
> + w->name, NULL);
> + ret = snd_ctl_add(card, kcontrol);

*sigh* As I wrote before in response to exactly the same code:

| Throughout this you've got coding style problems, you're not indenting
| the continuations of multi-line statements. Please try to follow the
| kernel coding style, if your code is visibly different to the rest of
| the codebase that's not good.

Please pay attention to review comments, just completely ignoring them
isn't good. If you don't feel some change should be made then reply and
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2014-09-11 21:21    [W:0.044 / U:2.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site