Messages in this thread | | | Date | Thu, 11 Sep 2014 12:53:25 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] tools lib fd array: Do not set fd as non blocking evlist |
| |
Em Thu, Sep 11, 2014 at 12:27:26PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Sep 11, 2014 at 05:09:43PM +0200, Jiri Olsa escreveu: > > > + fcntl(fd, F_SETFL, O_NONBLOCK); > > > > also I spot this one and couldn't think of reason for it, attached > > patch makes no behaviour difference for me.. > > Have to look why it is there, perhaps there is some changeset > specifically made for this, will do some research... > > > I might be missing something, but I dont see any blocking operation > > in perf related data reads. The git log history says it was there > > since early days. > > Oops, you did that research already, have you followed the history all > the way to when this code lived in Documentation/ ?
Since day one, found using:
$ git log -p --follow tools/perf/builtin-top.c
commit e0143bad9dbf2a8fad4c5430562bceba196b66ea Author: Ingo Molnar <mingo@elte.hu> Date: Mon Mar 23 21:29:59 2009 +0100
perf_counter: add sample user-space to Documentation/perf_counter/
Initial version of kerneltop.c and perfstat.c.
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
diff --git a/Documentation/perf_counter/kerneltop.c b/Documentation/perf_counter/kerneltop.c
Ingo, do we really need that O_NONBLOCK thing there?
- Arnaldo
| |