Messages in this thread | | | Date | Thu, 11 Sep 2014 13:24:34 +0100 | From | Nick Dyer <> | Subject | Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table |
| |
On 11/09/14 12:41, Javier Martinez Canillas wrote: > On 09/11/2014 01:35 PM, Wolfram Sang wrote: >>>> This is a workaround. It would make sense, however, to add it because we >>>> want to support i2c_board_info structures. >>>> >>> >>> I think it really depends if an IP block can be used on non-DT platforms >>> (which I think is true for this trackpad) but if a driver is for an IP block >>> that can only be used on a DT-only platform (e.g: a PMIC that is controlled >>> over I2C and is only compatible with a DT-only SoC) then I don't think we need >>> to support the i2c_board_info structure and can get rid of the I2C ID table on >>> these drivers once Lee series land. >> >> That is exactly what I meant. It should be only added if there is a >> reason other than "workaround". If you say, it doesn't make sense on >> non-DT, then it should not be added. > > Sorry for explaining myself badly. I just tried to say that this is a decision > that has to be made on a per-driver basis but I don't really know if makes > sense or not in this case since I don't know if this device is (or could be) > shipped on non-DT platforms. Nick is in a much better position to answer that > question.
There are plenty of out-of-tree users of this driver which don't use DT. The most significant use I'm aware of is on Chromium OS systems.
| |