lkml.org 
[lkml]   [2014]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/sl[aou]b: make kfree() aware of error pointers
On Wed, 10 Sep 2014, Theodore Ts'o wrote:

> I'd much rather depending on better testing and static checkers to fix
> them, since kfree *is* a hot path.

BTW if we stretch this argument a little bit more, we should also kill the
ZERO_OR_NULL_PTR() check from kfree() and make it callers responsibility
to perform the checking only if applicable ... we are currently doing a
lot of pointless checking in cases where caller would be able to guarantee
that the pointer is going to be non-NULL.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2014-09-10 17:01    [W:0.226 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site