lkml.org 
[lkml]   [2014]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

    Hi Xiubo

    Thank you for your patch.
    This clean-up is very nice for me.
    But, I have 1 small comment

    > asoc_simple_card_sub_parse_of(struct device_node *np,
    > struct asoc_simple_dai *dai,
    > struct device_node **p_node,
    > - const char **name)
    > + const char **name,
    > + unsigned int *daifmt)
    > {
    > struct device_node *node;
    > struct clk *clk;
    > u32 val;
    > int ret;
    >
    > + if (!daifmt)
    > + return -EINVAL;
    > +
    > + /*
    > + * Parse format, bitclock-inversion and frame-inversion
    > + * for DAI each device.
    > + */
    > + *daifmt = snd_soc_of_parse_daifmt(np, NULL, NULL, NULL);
    > + *daifmt &= ~(SND_SOC_DAIFMT_MASTER_MASK | SND_SOC_DAIFMT_FORMAT_MASK);
    (snip)
    > ret = asoc_simple_card_sub_parse_of(np, &dai_props->cpu_dai,
    > &dai_link->cpu_of_node,
    > - &dai_link->cpu_dai_name);
    > + &dai_link->cpu_dai_name,
    > + &daifmt);
    (snip)
    > + dai_props->cpu_dai.fmt |= daifmt;
    (snip)
    > ret = asoc_simple_card_sub_parse_of(np, &dai_props->codec_dai,
    > &dai_link->codec_of_node,
    > - &dai_link->codec_dai_name);
    > + &dai_link->codec_dai_name,
    > + &daifmt);
    (snip)
    > + dai_props->codec_dai.fmt |= daifmt;

    These are using

    asoc_simple_card_sub_parse_of(np, &dai_props->cpu_dai, xxx)
    asoc_simple_card_sub_parse_of(np, &dai_props->codec_dai, xxx)

    I guess, asoc_simple_card_sub_parse_of() can update
    below inside function

    dai_props->cpu_dai.fmt |= daifmt;
    dai_props->codec_dai.fmt |= daifmt;


    Best regards
    ---
    Kuninori Morimoto


    \
     
     \ /
      Last update: 2014-09-01 10:01    [W:7.268 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site