Messages in this thread | | | Date | Mon, 01 Sep 2014 18:08:49 +0100 | From | Sudeep Holla <> | Subject | Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI |
| |
Hi Mark,
On 01/09/14 17:58, Mark Brown wrote: > On Mon, Sep 01, 2014 at 05:53:33PM +0100, Catalin Marinas wrote: > >> Confused. Then how come smsc911x_drv_probe() has this line: > >> acpi_handle *ahandle = ACPI_HANDLE(&pdev->dev); > >> without any #ifdef's. > > There's a stub smsc911x_probe_config_acpi() provided in the non-ACPI > case, Arnd's suggestion is basically to remove the stub. >
I think Catalin is referring to ACPI_HANDLE used without any #ifdefs
Catalin, few macros like ACPI_HANDLE and ACPI_PTR are defined in include/linux/acpi.h even when CONFIG_ACPI is not set mainly to avoid #ifdef's around simple assignments like the above one and one in platform_driver.acpi_match_table
Regards, Sudeep
| |