lkml.org 
[lkml]   [2014]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/15] tty: serial: 8250_core: add run time pm
On 08/20/2014 11:39 AM, Frans Klaver wrote:

>>> static int serial8250_get_poll_char(struct uart_port *port)
>>> {
>>> - unsigned char lsr = serial_port_in(port, UART_LSR);
>>> + unsigned char lsr;
>>> + int status;
>>> +
>>> + serial8250_rpm_get(up);
>>
>> or up won't be defined below. You probably need
>
> Obviously I meant to say that 'up' won't be defined here.

Good catch, thanks. However I wouldn't bet my money it that won't be
defined here. The semaphore code provides up() and down() so it is
makes it kind of defined :) But it doesn't compile due to wrong pointer
types which is good (I run into this myself and looked confused at
first).
I didn't notice this at all because only kgdb uses this
CONFIG_CONSOLE_POLL which I had off. Once again, thank you.

>> + struct uart_8250_port *up = up_to_u8250p(port);
>> somewhere in there.

Sebastian


\
 
 \ /
  Last update: 2014-09-01 17:21    [W:0.094 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site