Messages in this thread | | | Subject | Re: [PATCH v1 2/5] mfd: lpc_sch: better code manageability with chipset info struct | From | Andy Shevchenko <> | Date | Mon, 01 Sep 2014 13:25:05 +0300 |
| |
On Mon, 2014-09-01 at 10:16 +0100, Lee Jones wrote: > On Fri, 22 Aug 2014, Andy Shevchenko wrote: > > > Introduce additional struct to hold chipset info. This chipset > > info will be used to store features that are supported by specific > > processor or chipset. LPC_SCH supports SMBUS, GPIO and WDT features. > > As this code base might expand further to support more processors, > > this implementation will help to keep code base clean and manageable. > > > > Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com> > > Tested-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[]
> The first patch would look a great deal cleaner if it had these > changes in too. Unless you have a really good reason not to, please > consider squashing them.
The only reason behind is that this patch (in other form) was written by Rebecca in the first place. I recommended to clean up before, and actually did that clean up and amended Rebecca's patch.
So, if Rebecca has now objections I could squash it.
-- Andy Shevchenko <andriy.shevchenko@intel.com> Intel Finland Oy
| |