Messages in this thread Patch in this message | | | Date | Fri, 8 Aug 2014 15:07:53 -0700 (PDT) | From | David Rientjes <> | Subject | [patch v2] mm, hugetlb_cgroup: align hugetlb cgroup limit to hugepage size |
| |
Memcg aligns memory.limit_in_bytes to PAGE_SIZE as part of the resource counter since it makes no sense to allow a partial page to be charged.
As a result of the hugetlb cgroup using the resource counter, it is also aligned to PAGE_SIZE but makes no sense unless aligned to the size of the hugepage being limited.
Align hugetlb cgroup limit to hugepage size.
Acked-by: Michal Hocko <mhocko@suse.cz> Signed-off-by: David Rientjes <rientjes@google.com> --- v2: use huge_page_order() per Aneesh Sorry for not cc'ing you initially, get_maintainer.pl failed me
mm/hugetlb_cgroup.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c @@ -275,6 +275,7 @@ static ssize_t hugetlb_cgroup_write(struct kernfs_open_file *of, ret = res_counter_memparse_write_strategy(buf, &val); if (ret) break; + val = ALIGN(val, 1ULL << huge_page_shift(&hstates[idx])); ret = res_counter_set_limit(&h_cg->hugepage[idx], val); break; default:
| |