lkml.org 
[lkml]   [2014]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH 03/11] PCI/MSI: Refactor pci_dev_msi_enabled()
From
On Fri, Jul 25, 2014 at 10:08 PM, Yijing Wang <wangyijing@huawei.com> wrote:
> Pci_dev_msi_enabled() is used to check whether device
> MSI/MSIX enabled. Refactor this function to suuport
> checking only device MSI or MSIX enabled.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>

So this patch refactors things so that checks like this:
> - if (!dev->msi_enabled)

are moved into a function:
> + if (!pci_dev_msi_enabled(dev, MSI_TYPE))

Can you explain a bit more why this needed. Is it just cleanup?

Thanks,
Stuart


\
 
 \ /
  Last update: 2014-08-06 00:41    [W:0.226 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site