Messages in this thread Patch in this message | | | From | Sasha Levin <> | Subject | [PATCH] kernel: smp: correct warning in on_each_cpu_cond | Date | Mon, 4 Aug 2014 17:02:23 -0400 |
| |
smp_call_function_single() returns 0 on success, not the other way around. Fix the warning to trigger on failure rather than success.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com> --- kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/smp.c b/kernel/smp.c index 487653b..aff8aa1 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -670,7 +670,7 @@ void on_each_cpu_cond(bool (*cond_func)(int cpu, void *info), if (cond_func(cpu, info)) { ret = smp_call_function_single(cpu, func, info, wait); - WARN_ON_ONCE(!ret); + WARN_ON_ONCE(ret); } preempt_enable(); } -- 1.7.10.4
| |