lkml.org 
[lkml]   [2014]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty: serial: msm: fix checkpatch warnings
On Mon, Aug 04, 2014 at 07:50:46PM +0530, Kiran Padwal wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: braces {} are not necessary for any arm of this statement
>
> WARNING: Missing a blank line after declarations
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> WARNING: else is not generally useful after a break or return
>
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Kiran Padwal <kiran.padwal@smartplayin.com>
> ---
> drivers/tty/serial/msm_serial.c | 26 +++++++++++---------------
> 1 file changed, 11 insertions(+), 15 deletions(-)

That's a lot of different things all mushed into one patch. Please
break this up into "one change per patch" so we can review it better.

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-08-04 21:21    [W:0.047 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site