lkml.org 
[lkml]   [2014]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 26/94] ext4: clarify error count warning messages
    3.2.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit ae0f78de2c43b6fadd007c231a352b13b5be8ed2 upstream.

    Make it clear that values printed are times, and that it is error
    since last fsck. Also add note about fsck version required.

    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Reviewed-by: Andreas Dilger <adilger@dilger.ca>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/ext4/super.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -2726,10 +2726,11 @@ static void print_daily_error_info(unsig
    es = sbi->s_es;

    if (es->s_error_count)
    - ext4_msg(sb, KERN_NOTICE, "error count: %u",
    + /* fsck newer than v1.41.13 is needed to clean this condition. */
    + ext4_msg(sb, KERN_NOTICE, "error count since last fsck: %u",
    le32_to_cpu(es->s_error_count));
    if (es->s_first_error_time) {
    - printk(KERN_NOTICE "EXT4-fs (%s): initial error at %u: %.*s:%d",
    + printk(KERN_NOTICE "EXT4-fs (%s): initial error at time %u: %.*s:%d",
    sb->s_id, le32_to_cpu(es->s_first_error_time),
    (int) sizeof(es->s_first_error_func),
    es->s_first_error_func,
    @@ -2743,7 +2744,7 @@ static void print_daily_error_info(unsig
    printk("\n");
    }
    if (es->s_last_error_time) {
    - printk(KERN_NOTICE "EXT4-fs (%s): last error at %u: %.*s:%d",
    + printk(KERN_NOTICE "EXT4-fs (%s): last error at time %u: %.*s:%d",
    sb->s_id, le32_to_cpu(es->s_last_error_time),
    (int) sizeof(es->s_last_error_func),
    es->s_last_error_func,


    \
     
     \ /
      Last update: 2014-08-04 19:21    [W:4.233 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site