Messages in this thread | | | Subject | Re: checkpatch.pl report about "Missing blank line after declarations" in a structure definition | From | Joe Perches <> | Date | Mon, 04 Aug 2014 06:35:42 -0700 |
| |
On Mon, 2014-08-04 at 11:20 +0000, Dotan Barak wrote: > Hi Joe. > > Thanks for fixing the issue that I reported about. > > It seems that even after your fix, there is still a false warning of "Missing blank line after declarations". > > I executed checkpatch.pl on a header file that exists in the Linux tree: > # ./checkpatch.pl --file --no-tree ../include/linux/mlx5/cq.h > > And got the following warning: > > WARNING: Missing a blank line after declarations > #49: FILE: ../include/linux/mlx5/cq.h:49: > + int irqn; > + void (*comp) (struct mlx5_core_cq *); [] > As you can see, this is a structure definition and IMHO the warning above is false.
The version in Linus' tree has a defect where this test doesn't recognize function pointer declarations.
This is fixed in -next since June, but it takes awhile to get into Linus' tree.
https://lkml.org/lkml/2014/6/6/426
| |