lkml.org 
[lkml]   [2014]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH V2 1/1] GIC: introduce method to deactive interupts
Date
When using kdump on ARM platform, if kernel panics in interrupt handler
(maybe PPI), the capture kernel can not recive certain interrupt, and
fails to boot.

On this situation, We have read register GICC_IAR. But we have no chance
to write relative bit to register GICC_EOIR (kernel paniced before). So
the state of this type interrupt remains active. And that makes gic not
deliver this type interrupt to cpu interface.

So we should not assume that all interrut states of GIC are inactive when
kernel inittailize the GIC. This patch will identify these type interrupts
and deactive them

Signed-off-by: Liu Hua <sdu.liu@huawei.com>
---
drivers/irqchip/irq-gic.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index b2648fc..7708df1 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -351,12 +351,37 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)
return mask;
}

+void gic_eois(u32 active, int irq_off, void __iomem *cpu_base)
+{
+ int bit = -1;
+
+ for_each_set_bit(bit, (unsigned long *)&active, 32)
+ writel_relaxed(bit + irq_off, cpu_base + GIC_CPU_EOI);
+}
+
+void gic_dist_clear_active(void __iomem *dist_base,
+ void __iomem *cpu_base, int gic_irqs)
+{
+ int irq, offset;
+ u32 active;
+
+ for (irq = 0; irq < gic_irqs; irq += 32) {
+ offset = GIC_DIST_ACTIVE_SET + irq * 4 / 32;
+ active = readl_relaxed(dist_base + offset);
+ if (!active)
+ continue;
+ gic_eois(active, irq, cpu_base);
+ }
+}
+
+
static void __init gic_dist_init(struct gic_chip_data *gic)
{
unsigned int i;
u32 cpumask;
unsigned int gic_irqs = gic->gic_irqs;
void __iomem *base = gic_data_dist_base(gic);
+ void __iomem *cpu_base = gic_data_cpu_base(gic);

writel_relaxed(0, base + GIC_DIST_CTRL);

@@ -371,6 +396,7 @@ static void __init gic_dist_init(struct gic_chip_data *gic)

gic_dist_config(base, gic_irqs, NULL);

+ gic_dist_clear_active(base, cpu_base, gic_irqs);
writel_relaxed(1, base + GIC_DIST_CTRL);
}

--
1.9.0


\
 
 \ /
  Last update: 2014-08-04 07:01    [W:0.067 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site