lkml.org 
[lkml]   [2014]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings
From
On Sat, Aug 30, 2014 at 5:40 AM, Ian Abbott <abbotti@mev.co.uk> wrote:
>
> That seems fine. Perhaps the variable 'p' in usbdux_ao_insn_write() should
> also be of type '__le16 *'?
>

You're entirely correct. I had seen this in the output from Sparse,
but for some reason at first glance I had convinced myself that the
fix would be more complicated than it is. I'll get a patch out with a
Suggested-by: tag for you very soon.

Thanks,
Chase

> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
> -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-


\
 
 \ /
  Last update: 2014-08-31 21:21    [W:0.185 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site