Messages in this thread | | | Date | Sat, 30 Aug 2014 14:01:28 -0700 | From | Greg KH <> | Subject | Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings |
| |
On Sat, Aug 30, 2014 at 10:54:32PM +0300, Ramon Fried wrote: > This patch fixes the following checkpatch.pl warnings: > > WARNING: Possible unnecessary 'out of memory' message > #146: FILE: ./xlr_net.c:146: > + if (!skb) { > + pr_err("SKB allocation failed\n"); > > WARNING: Missing a blank line after declarations > #1107: FILE: ./xlr_net.c:1107: > + struct xlr_net_priv *priv = platform_get_drvdata(pdev); > + unregister_netdev(priv->ndev);
> >From 27b58d9b1d39ab99bf6022b82ac9e602621b2822 Mon Sep 17 00:00:00 2001 > From: Ramon Fried <ramon.fried@gmail.com> > Date: Sat, 30 Aug 2014 22:26:11 +0300 > Subject: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings > > Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
WHy did you not put the information above in the changelog area here?
And why send a patch as an attachment, I can't do much of anything with that :(
Also, please use the scripts/get_maintainer.pl tool to determine who and what mailing lists to cc: for a patch.
Please fix this up and resend.
thanks,
greg k-h
| |