lkml.org 
[lkml]   [2014]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: stmmac: fix warning from Sparse for socfpga
From
On Thu, Aug 28, 2014 at 7:33 AM, David Miller <davem@davemloft.net> wrote:
> From: Ley Foon Tan <lftan@altera.com>
> Date: Tue, 26 Aug 2014 15:11:16 +0800
>
>> @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
>> return -EINVAL;
>> }
>>
>> - dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
>> + dwmac->splitter_base =
>> + (void __iomem *)devm_ioremap_resource(dev,
>> &res_splitter);
>
> Please either put this entire call on one line (it'll only be slightly
> over 80 columns, which is fine), or indent it properly.
>
> And by properly I meant that the second and subsequent lines of a function
> call must be indented precisely to the first column after the openning
> parenthesis of the function call on the first line. You must use the
> appropriate number of TAB and SPACE characters necessary to do so.
>
> If it is indented using only TAB characters, it is very likely that you
> are doing it wrong.
Okay, will send in new patch to fix this.
Thanks.


\
 
 \ /
  Last update: 2014-08-28 05:41    [W:0.479 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site