Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Allow commit descriptions on separate line from commit id | From | Joe Perches <> | Date | Wed, 27 Aug 2014 18:38:21 -0700 |
| |
The general form for commit id and description is
'Commit <12+hexdigits> ("commit description/subject line")'
But commit logs often have relatively long commit ids and the commit description is on a separate line like:
Some explanation as to why commit <12+hexdigits> ("commit description/subject line") is improved.
Allow this form.
Signed-off-by: Joe Perches <joe@perches.com> Suggested-by: Joe Lawrence <joe.lawrence@stratus.com Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d89857d..4d869dd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2133,7 +2133,10 @@ sub process { # Check for improperly formed commit descriptions if ($in_commit_log && $line =~ /\bcommit\s+[0-9a-f]{5,}/i && - $line !~ /\b[Cc]ommit [0-9a-f]{12,40} \("/) { + !($line =~ /\b[Cc]ommit [0-9a-f]{12,40} \("/ || + ($line =~ /\b[Cc]ommit [0-9a-f]{12,40}\s*$/ && + defined $rawlines[$linenr] && + $rawlines[$linenr] =~ /^\s*\("/))) { $line =~ /\b(c)ommit\s+([0-9a-f]{5,})/i; my $init_char = $1; my $orig_commit = lc($2);
| |