lkml.org 
[lkml]   [2014]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups
On Wed, Aug 27, 2014 at 12:21 PM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> On Wed, Aug 27, 2014 at 10:13:50AM +0530, Amit Shah wrote:

>>
>> Yes, this patch helps my case as well.
>
> Very good!!!
>
> Pranith, I can take this patch, but would you be willing to invert
> the sense of ->nocb_leader_wake (e.g., call it ->nocb_leader_sleep or
> some such)? This field is only used in eight places in the source code.
>
> The idea is that inverting the sense of the field allows the normal C
> initialization of zero to properly initialize this field, plus it gets
> rid of a few lines of code.
>

Sure, that is indeed a good idea. I will send a new patch.

--
Pranith


\
 
 \ /
  Last update: 2014-08-27 19:01    [W:0.106 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site