Messages in this thread | | | Date | Wed, 27 Aug 2014 11:04:42 +0300 | From | Mika Westerberg <> | Subject | Re: [Bugfix] x86, irq: Fix bug in setting IOAPIC pin attributes |
| |
On Wed, Aug 27, 2014 at 01:53:11PM +0800, Jiang Liu wrote: > Commit 15a3c7cc9154321fc3 "x86, irq: Introduce two helper functions > to support irqdomain map operation" breaks LPSS ACPI enumerated > devices. > > On startup, IOAPIC driver preallocates IRQ descriptors and programs > IOAPIC pins with default level and polarity attributes for all legacy > IRQs. Later legacy IRQ users may fail to set IOAPIC pin attributes > if the requested attributes conflicts with the default IOAPIC pin > attributes. So change mp_irqdomain_map() to allow the first legacy IRQ > user to reprogram IOAPIC pin with different attributes. > > Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> > --- > Hi Mika, > We have a plan to kill function mp_set_gsi_attr() later, so > I have slightly modified your changes. Could you please help to test > it again?
Works fine here, thanks!
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
| |