lkml.org 
[lkml]   [2014]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] HID: logitech-dj: prevent false errors to be shown
On Mon, 25 Aug 2014, Markus Trippelsdorf wrote:

> > > Commit "HID: logitech: perform bounds checking on device_id early
> > > enough" unfortunately leaks some errors to dmesg which are not real
> > > ones:
> > > - if the report is not a DJ one, then there is not point in checking
> > > the device_id
> > > - the receiver (index 0) can also receive some notifications which
> > > can be safely ignored given the current implementation
> > >
> > > Move out the test regarding the report_id and also discards
> > > printing errors when the receiver got notified.
> > >
> > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >
> > I have now queued this one for 3.17. Adding Markus to CC -- Markus, this
> > should make the spurious error messages you have reported go away.
>
> Indeed it does. Feel free to add:
>
> Reported-and-tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>

Excellent, thanks. Will be pushing it to Linus this week.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2014-08-25 10:21    [W:0.054 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site