lkml.org 
[lkml]   [2014]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB
On 08/18/2014 11:08 AM, Andrew Bresticker wrote:
> Add new bindings used for USB support by the Tegra XUSB pad controller.
> This includes additional PHY types, USB-specific pinconfig properties, etc.

I'll mainly defer to Thierry for this patch, since he's the expert on
this HW module.

> diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt

> - #phy-cells: Should be 1. The specifier is the index of the PHY to reference.
> See <dt-bindings/pinctrl/pinctrl-tegra-xusb.h> for the list of valid values.
> +- mboxes: Must contain an entry for the XUSB PHY mailbox channel.
> + See ../mailbox/mailbox.txt for details.

Can we require the mbox-names property here, so that everything is
looked up by names. I know that the proposed mbox binding states that
using indexes is preferred over names, but that's just silly considering
that names are widely used in most other similar bindings, and are much
easier to extend in a backwards compatible fashion in the face of
optional entries. As such, I'd prefer that all Tegra bindings use
foo-names properties where they exist.

> +Optional properties:
> +-------------------
> +- vbus-otg-{0,1,2}-supply: VBUS regulator for the corresponding UTMI pad.

Why "-otg"? It's quite possible to have a regulator for VBUS even on
systems that don't support OTG, but rather simply have the ability to
turn VBUS off.


> - pcie-0, pcie-1, pcie-2, pcie-3, pcie-4, sata-0:
>
> Valid functions for this group are: "pcie", "usb3", "sata", "rsvd".
>
> + The nvidia,usb2-port-num property only applies and is required when
> + the function is usb3.
> +
>

There are 2 blank lines there.



\
 
 \ /
  Last update: 2014-08-25 21:21    [W:0.271 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site