lkml.org 
[lkml]   [2014]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [hyperv] BUG at drivers/hv/channel.c:462 while changing MTU
On Mon, Aug 25, 2014 at 05:34:27PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> > Sent: Monday, August 25, 2014 2:37 AM
> > To: Sitsofe Wheeler
> > Cc: KY Srinivasan; Greg Kroah-Hartman; Jason Wang; linux-
> > kernel@vger.kernel.org; David S. Miller; Daniel Borkmann;
> > netdev@vger.kernel.org; devel@linuxdriverproject.org; Haiyang Zhang
> > Subject: Re: [hyperv] BUG at drivers/hv/channel.c:462 while changing MTU
> >
> > The code here is:
> >
> > drivers/hv/channel.c
> > 460 BUG_ON(ret != 0);
> > 461 t = wait_for_completion_timeout(&info->waitevent, 5*HZ);
> > 462 BUG_ON(t == 0);
> >
> > So it calls BUG_ON() if the teardown takes more than 5 seconds. It's most
> > likely that there is a race condition somewhere. It's also possible that it's just
> > taking longer than 5 seconds for some odd reason and the bug would go
> > away if we raised it to 60 seconds.
> >
> > BUG_ON() after 5 seconds seems like a very aggressive thing.
>
> Dan,
>
> I am going to audit all BUG_ON() instances.

Please remove them all, no kernel driver should ever crash the kernel
and not give a user a chance to recover :(

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-08-25 20:01    [W:0.060 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site