lkml.org 
[lkml]   [2014]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] checkpatch: look for common misspellings
From
On Fri, Aug 22, 2014 at 4:22 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2014-08-22 at 23:00 +0000, Elliott, Robert (Server Storage)
> wrote:
>> > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
>> > owner@vger.kernel.org] On Behalf Of Joe Perches
>> ...
>> > +chang||change
>>
>> Although there are at least 2 misuses in the current kernel,
>> that's also a fairly common name.
>
> True. Thanks.
>
> That one should likely be removed.
> There are dozens of Chang name uses in the kernel.

Right, I removed a bunch similar things like this.

> I'm not attached at all to any of these btw.
>
> Any others you think should not be used or
> should be added?
>
> One I thought kind of iffy was
>
> contant||contact
>
> Maybe that should be content instead.

Or "constant". I'll go through the list and see if anything stands out.

> Another thing the script might do is to check
> if the $typo match is all upper case and then
> substitute an all upper case $typo_fix.

That might be a good idea.

> It's also kind of noisy when run using -f,
> so maybe this test should be --strict check with
> files and a warning with patches.

Sure, seems reasonable. I'll get a v2 spun up.

-Kees

--
Kees Cook
Chrome OS Security


\
 
 \ /
  Last update: 2014-08-23 02:01    [W:0.055 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site