Messages in this thread | | | From | "Murphy, Dan" <> | Subject | Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton | Date | Thu, 21 Aug 2014 17:32:00 +0000 |
| |
On 08/21/2014 12:19 PM, Menon, Nishanth wrote: > On 08/21/2014 11:59 AM, Murphy, Dan wrote: > [...] > Ooops.. missed answering one addition statement: > >>> + of_property_read_u32(np, "ti,palmas-long-press-seconds", &val); >> >> Probably should check the return to make sure the value exists and that is is >> within an expected range. > It is an optional parameter and may not exist in dt. when it does > exist, the logic tries to do a best match (this is the for loop in the > logic just below). >
The issue is val might be returned as a negative which will then proceed to set the config->long_press_time_val to the lowest time value which then overrides your initial setting of config->long_press_time_val = ARRAY_SIZE(lpk_times) - 1;
Dan
-- ------------------ Dan Murphy
| |