lkml.org 
[lkml]   [2014]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton
    Hi Nishanth,

    On Thu, Aug 21, 2014 at 11:02:15AM -0500, Nishanth Menon wrote:
    > +
    > + ret = input_register_device(input_dev);
    > + if (ret) {
    > + free_irq(irq, pwron);

    You can not use free_irq with devm-managed resources. As I mentioned, since you
    need manual unwinding, I'd rather you not use managed resources in the driver
    at all.

    > + cancel_delayed_work_sync(&pwron->input_work);
    > + dev_dbg(dev, "Can't register power button: %d\n", ret);
    > + return ret;

    Thanks.

    --
    Dmitry


    \
     
     \ /
      Last update: 2014-08-21 19:41    [W:7.468 / U:1.836 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site