Messages in this thread | | | Date | Thu, 21 Aug 2014 14:37:21 +0200 | Subject | Re: [PATCH v3 03/11] drivers: base: add new class "cpu" to group cpu devices | From | David Herrmann <> |
| |
Hi
On Thu, Aug 21, 2014 at 2:30 PM, Sudeep Holla <sudeep.holla@arm.com> wrote: > On 21/08/14 12:20, David Herrmann wrote: >> Why do we need a cpu-class if the same set of information is already >> available on the cpu-bus? Furthermore, classes are deprecated anyway. >> Everything you can do with a class can be solved with a bus. And we >> already have a bus for cpus. >> > > This was suggested[1] by GregKH. The main reason it was added is to > reuse the device attributes rather than creating the raw kobjects. > > It helps to move few other cpu related subsystems using raw kobjects to > the device attribute groups.
So the only reason to add a class is to get attributes registered properly with the device? Just set dev->groups before calling device_add()? This works just fine on buses, too.
Thanks David
| |