lkml.org 
[lkml]   [2014]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH v2 1/2] mfd: arizona: Add support for INn_Mode register control
On Wed, 13 Aug 2014, Inha Song wrote:

> Some boards need to set the INn_MODE[1:0] register to change
> the input signal patch. This wlf,inmode property is optional.
> If present values must be specified by the number of
> ARIZONA_MAX_INPUT.
>
> Example:
> - wlf,inmode = <2 0 2 0>; /* IN1, IN3 use DMIC */
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
> drivers/mfd/arizona-core.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)

This is going to require a DT Ack.

Is [2/2] adding the documentation? I can't easily go and look because
you send the patch-set unthreaded. Please thread patch-sets. See
the man page for `git send-email` for more information.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 10a0cb9..2b68ccd 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio);
> static int arizona_of_get_core_pdata(struct arizona *arizona)
> {
> struct arizona_pdata *pdata = &arizona->pdata;
> - int ret, i;
> + int ret, i, proplen;
>
> pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true);
>
> @@ -560,6 +560,15 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> ret);
> }
>
> + proplen = of_property_count_u32_elems(arizona->dev->of_node,
> + "wlf,inmode");
> + if (proplen > 0 && proplen <= ARRAY_SIZE(arizona->pdata.inmode)) {
> + for (i = 0; i < proplen; i++)
> + of_property_read_u32_index(arizona->dev->of_node,
> + "wlf,inmode", i,
> + &arizona->pdata.inmode[i]);
> + }
> +
> return 0;
> }
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-08-21 14:41    [W:0.099 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site