lkml.org 
[lkml]   [2014]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 5/6] KVM: trace kvm_ple_window
2014-08-21 10:29+0200, Paolo Bonzini:
> Il 20/08/2014 22:53, Radim Krčmář ha scritto:
> > Tracepoint for dynamic PLE window, fired on every potential change.
> >
> > Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> > ---
> > arch/x86/kvm/trace.h | 25 +++++++++++++++++++++++++
> > arch/x86/kvm/vmx.c | 8 +++++---
> > arch/x86/kvm/x86.c | 1 +
> > 3 files changed, 31 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> > index e850a7d..4b8e6cb 100644
> > --- a/arch/x86/kvm/trace.h
> > +++ b/arch/x86/kvm/trace.h
> > @@ -848,6 +848,31 @@ TRACE_EVENT(kvm_track_tsc,
> > __print_symbolic(__entry->host_clock, host_clocks))
> > );
> >
> > +TRACE_EVENT(kvm_ple_window,
> > + TP_PROTO(int grow, unsigned int vcpu_id, int new, int old),
>
> s/int grow/bool grow/ (and similarly in TP_STRUCT__entry).

Ok.
(We are using 'int' for this in other tracepoints, so I guessed there is
some hate agains bool.)

> > + TP_ARGS(grow, vcpu_id, new, old),
> > +
> > + TP_STRUCT__entry(
> > + __field( int, grow )
> > + __field( unsigned int, vcpu_id )
> > + __field( int, new )
> > + __field( int, old )
> > + ),
> > +
> > + TP_fast_assign(
> > + __entry->grow = grow;
> > + __entry->vcpu_id = vcpu_id;
> > + __entry->new = new;
> > + __entry->old = old;
> > + ),
> > +
> > + TP_printk("vcpu %u: ple_window %d %s %d",
> > + __entry->vcpu_id,
> > + __entry->new,
> > + __entry->grow ? "<+" : "<-",
>
> ? "grow" : "shrink"

Can't say I haven't expected comment about that :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-08-21 14:21    [W:0.073 / U:1.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site