lkml.org 
[lkml]   [2014]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kbuild: Make scripts executable
On 2014-08-21 05:25, Masahiro Yamada wrote:
> Hi Michal,
>
>
> On Wed, 20 Aug 2014 16:10:48 +0200
> Michal Marek <mmarek@suse.cz> wrote:
>
>> The Makefiles call the respective interpreter explicitly, but this makes
>> it easier to use the scripts manually.
>>
>> Signed-off-by: Michal Marek <mmarek@suse.cz>
>
>
> I am not sure at all, but
> it seems scripts/checkpatch.pl has a rule
> to ban execute permissions.

I didn't know about this, but the intent of the rule seems to be to
avoid *.c files with execute permissions.


> # Check for incorrect file permissions
> if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
> my $permhere = $here . "FILE: $realfile\n";
> if ($realfile !~ m@scripts/@ &&
> $realfile !~ /\.(py|pl|awk|sh)$/) {

Here it explicitly skips files below scripts/ and files with known
script suffixes.

Michal


\
 
 \ /
  Last update: 2014-08-21 11:41    [W:0.282 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site