lkml.org 
[lkml]   [2014]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable
On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote:
> On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon <mark.einon@gmail.com> wrote:
>
> > do {
> > pci_read_config_dword(pdev,
> > - LBCIF_DATA_REGISTER, &val);
> > + LBCIF_DATA_REGISTER,
> > + &val);
>
> This seems to be an unrelated change.

Hi Fabio, thanks for the review.

It's a space alignment of parameters to go with the previous change, to
keep wrapping consistent in the file:

- while (i2c_wack) {
+ while (1) {
if (pci_write_config_byte(pdev, LBCIF_CONTROL_REGISTER,
- LBCIF_CONTROL_LBCIF_ENABLE))
+ LBCIF_CONTROL_LBCIF_ENABLE))

So what are you saying - are you just commenting, document it, put it
in a seperate patch?

Cheers,

Mark


\
 
 \ /
  Last update: 2014-08-21 11:41    [W:0.150 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site