Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 3/3] ARM: at91/tclib: mask interruptions at shutdown and probe | Date | Thu, 21 Aug 2014 05:32:59 +0200 |
| |
On Wednesday 20 August 2014, Gaël PORTAY wrote: > +static void tc_shutdown (struct platform_device *pdev) > +{ > + int i; > + struct atmel_tc *tc = platform_get_drvdata(pdev); > + > + for (i = 0; i < 3; i++) > + __raw_writel(0xff, tc->regs + ATMEL_TC_REG(i, IDR)); > +}
In general, __raw_readl/__raw_writel are not meant to be called by device drivers.
Just use readl/writel by default, or readl_relaxed/writel_relaxed if the code is performance critical and you are sure it is safe to use them.
Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |